add: es_output(WIP)#39
Draft
sugihara1997 wants to merge 1 commit into
Draft
Conversation
syama666
reviewed
Oct 10, 2023
| func createChangeStreamIndexSchema(cs primitive.M) (ChangeStreamIndexSchema, error) { | ||
| var schema ChangeStreamIndexSchema | ||
|
|
||
| idData, err := getMap(cs, "_id") |
Collaborator
There was a problem hiding this comment.
この関数群の実装（getStringとかgetMapとか）って全てのinterfacesesにあるんだと思うんだけど（見てないけ）、 もしMongoのバージョンが進んでchangeStreamの型が変わることがあれば、全部変更しないといけない？
Collaborator
There was a problem hiding this comment.
一旦このbranchでテスト進めてOKんだけど、mainブランチにマージされる直前までには直ってると嬉しい
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Elasticsearch への output を追加しました。
環境変数
ELASTICSEARCH_SYNC_ENABLEDで、かを選択できるようにしています。
mxt から es への接続は url への埋め込みによる base 認証を前提としています。